Small fixes and updates #207
Conversation
|
Changes look good |
There was a problem hiding this comment.
Pull request overview
This pull request addresses documentation improvements for lab instructions including typo corrections, formatting fixes, and updated images. The changes span across four lab instruction files (LAB06, LAB07, LAB08, LAB09) and multiple PNG image files.
Changes:
- Corrected spelling errors ("Jon Doe" to "John Doe")
- Fixed control naming format (contoso_contoso_timelinecontrol to contoso_contoso.timelinecontrol)
- Standardized Markdown formatting and indentation
- Added "use strict" directives to JavaScript code examples
- Modified Azure Function App naming instructions
- Added new Back button instructions to LAB09
- Updated and replaced multiple screenshot images
Reviewed changes
Copilot reviewed 4 out of 32 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Instructions/Labs/LAB[PL-400]_Lab09_Azure.md | Added region specifications, updated function naming guidance, corrected method references, added Back button instructions, removed redundant screenshots |
| Instructions/Labs/LAB[PL-400]_Lab08_Plugins.md | Fixed spelling of "John Doe" placeholder name |
| Instructions/Labs/LAB[PL-400]_Lab07_PCF.md | Corrected custom control naming format |
| Instructions/Labs/LAB[PL-400]_Lab06_Client_Scripting.md | Standardized indentation, reorganized web resource creation steps, added "use strict" directives, removed one "Save & Close" instruction |
| Instructions/images/L06/*.png | Updated multiple screenshot images (15 files) |
| Instructions/images/L08/Mod_01_Plugin_image69.png | Updated screenshot image |
| Instructions/images/L09/*.png | Updated screenshot images (4 files) |
Comments suppressed due to low confidence (1)
Instructions/Labs/LAB[PL-400]_Lab06_Client_Scripting.md:735
- The instruction "Select Save & Close" was removed after creating the Custom API Response Property. However, looking at the pattern in this section, the previous steps (lines 698 and 717) include "Select Save & Close" followed by "Select Done", while line 734 shows "Select Save and Close" (with "and" instead of "&"). This inconsistency should be addressed - either all three steps should include the Save & Close instruction, or it should be removed from all three for consistency. The current state where two have it and one doesn't is confusing.
- Select **Save and Close**.
- Select **Done**.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - Enter `pl400wh` followed by your initials and a unique number for Function App name. | ||
|
|
||
| > Note: Function app name must be unique across Azure. Wait until you see a green tick to confirm the name is unique. | ||
| - Enter `pl400wh` for Function App name. |
There was a problem hiding this comment.
The removal of the note about Function App name uniqueness and the specific naming pattern guidance may cause issues for users. Azure Function App names must be globally unique across Azure. The original instruction to add "initials and a unique number" helped ensure uniqueness. Simply using "pl400wh" will likely fail for most users as this name may already be taken. Consider keeping guidance about uniqueness or providing an alternative approach such as adding a unique suffix.
| - Enter `pl400wh` for Function App name. | |
| - Enter a globally unique Function App name, for example `pl400wh<your-initials><unique-number>` (Function App names must be unique across Azure). |
| 1. Add another button. | ||
| - Select **+ Insert** tab. | ||
|
|
||
| - Select Button |
There was a problem hiding this comment.
On line 1022, "Select Button" is missing the period at the end to match the formatting of the other bullet points in this section. For consistency with lines 1020, 1024, etc., this should be "Select Button."
| - Select Button | |
| - Select **Button**. |
| This lab focuses on both inbound and outbound integration with Azure. In this lab you will: | ||
|
|
||
| 1) Use the event publishing capability of Microsoft Dataverse. When a permit results in changing the size of the build site, an external taxing authority needs to be notified so they can evaluate if additional taxing is required. You will configure Microsoft Dataverse to publish permits with size changes using the Webhook. To simulate the taxing authority receiving the information you will create a simple Azure function to receive the post. | ||
| 1. Use the event publishing capability of Microsoft Dataverse. When a permit results in changing the size of the build site, an external taxing authority needs to be notified so they can evaluate if additional taxing is required. You will configure Microsoft Dataverse to publish permits with size changes using the Webhook. To simulate the taxing authority receiving the information you will create a simple Azure function to receive the post. |
There was a problem hiding this comment.
The numbered list formatting has been changed from "1)" to "1." which is correct Markdown syntax. However, only the first item has been changed. For consistency, all numbered list items in this section should use the same format. The second item on line 15 still appears to start with "1." based on the context, but it's important to verify that the entire numbered list follows consistent formatting.
2 participants
Changes proposed in this pull request: